RFR: 8328331: Rename files 'blockOffsetTable.[h|c]pp' to 'BOTConstants.[h|c]pp'
Guoxiong Li
gli at openjdk.org
Mon Mar 18 14:41:29 UTC 2024
On Mon, 18 Mar 2024 14:18:56 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
> Maybe a simplification in this area can be removing the redundant fields of `BOTConstants` and `CardTable`?
If we remove the redundant fields of `BOTConstants`, we need to include `CardTable` header in files related to `BOTConstants`. Not really know whether it deserves it.
> I feel the filename `blockOffsetTable` is more consistent with some of its collector-specific specializations, e.g. serialBlockOffsetTable, so the current filename looks fine.
>
> The mismatch btw the filename and the class name is indeed undesirable. Looking at how this class is used, its name is used to call its static methods, so renaming it to sth longer impairs readability IMO. (The diff will be quite large as well, without much benefit.)
Got it. If no one has other opinion, I will close this PR.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18342#issuecomment-2004098728
More information about the hotspot-gc-dev
mailing list