RFR: 8328278: Serial: Compute tenuring threshold before GC

[Y. Srinivas Ramakrishna]

On Fri, 15 Mar 2024 15:59:58 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> 
> This patch places the SerialGC code that computes tenuring threshold before per GC instead of after per GC, so that the method `AgeTable::print_on` prints the right tenuring threshold. Just like the current G1 implementation.
> 
> Thanks for taking the time to review.
> 
> Best Regards,
> -- Guoxiong

Where you state above that:

> Then the message we print, Age table with threshold 12, is strange, because the age table we then print has 14 rows of non-zero values.

That's OK, because the threshold 12 is the new threshold computed based on the age table stats presented in the table, corresponding to the demographics recorded in _this_ collection. The new tenuring threshold will be used in the next collection.

May be we can start by sharing, as I requested in my previous comment, with a G1GC and a SerialGC log and discuss what is the bug you are trying to fix. It's better to use concrete examples rather than just describing the output in English sentences.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18329#issuecomment-2005559476