RFR: 8328278: Serial: Compute tenuring threshold before GC

Guoxiong Li gli at openjdk.org
Tue Mar 19 02:56:20 UTC 2024


On Fri, 15 Mar 2024 15:59:58 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> 
> This patch places the SerialGC code that computes tenuring threshold before per GC instead of after per GC, so that the method `AgeTable::print_on` prints the right tenuring threshold. Just like the current G1 implementation.
> 
> Thanks for taking the time to review.
> 
> Best Regards,
> -- Guoxiong

> That's OK, because the threshold 12 is the new threshold computed based on the age table stats presented in the table, corresponding to the demographics recorded in this collection. The new tenuring threshold will be used in the next collection.

> So what we should do now is decide which behaviour is right and unify the behaviour of these two GCs.

And now, I lean to agree with you that the new threshold should be printed. The message `Age table with threshold %u` can be interpreted as: the threshold is computed according to the following age table.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18329#issuecomment-2005653515


More information about the hotspot-gc-dev mailing list