RFR: 8328508: Unify the signatures of the methods 'address_for_index' and 'index_for' [v2]
Guoxiong Li
gli at openjdk.org
Thu Mar 21 00:40:33 UTC 2024
> Hi all,
>
> This patch unifies the related methods of the block offset table in Serial, Parallel and GC. It mainly removes the methods `SerialBlockOffsetSharedArray::address_for_index`, `SerialBlockOffsetSharedArray::index_for`, `G1BlockOffsetTable::address_for_index` and `G1BlockOffsetTable::index_for` and adds the corresponding methods `addr_for_entry` and `entry_for_addr`. Their usages and the signatures of other methods are also adjusted.
>
> I find some duplicated code of the block offset table in Serial and Parallel (and less in G1). Maybe, we should refactor the block offset table to reduce the duplicated code in the future.
>
> Tier-1 is running locally.
>
> Thanks for taking the time to review.
>
> Best Regards,
> -- Guoxiong
Guoxiong Li has updated the pull request incrementally with two additional commits since the last revision:
- Revert ObjectStartArray::block_start_reaching_into_card
- Drop unnecessary type conversion.
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/18405/files
- new: https://git.openjdk.org/jdk/pull/18405/files/5d156e11..47fcabe4
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=18405&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=18405&range=00-01
Stats: 13 lines in 2 files changed: 8 ins; 1 del; 4 mod
Patch: https://git.openjdk.org/jdk/pull/18405.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/18405/head:pull/18405
PR: https://git.openjdk.org/jdk/pull/18405
More information about the hotspot-gc-dev
mailing list