RFR: 8328508: Unify the signatures of the methods 'address_for_index' and 'index_for' [v2]

Guoxiong Li gli at openjdk.org
Thu Mar 21 07:38:20 UTC 2024


On Thu, 21 Mar 2024 00:37:31 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> src/hotspot/share/gc/parallel/objectStartArray.inline.hpp line 48:
>> 
>>> 46: HeapWord* ObjectStartArray::block_start_reaching_into_card(HeapWord* const addr) const {
>>> 47:   const uint8_t* entry = entry_for_addr(addr);
>>> 48:   uint8_t offset = *entry;
>> 
>> I kind of like the original style, as it has a single de-reference. (It's indeed rather subjective.) Also, this change is completely unrelated to this ticket.
>
> Reverted.

Should I revert the `SerialBlockOffsetTable::block_start_reaching_into_card` too?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18405#discussion_r1533361981


More information about the hotspot-gc-dev mailing list