Integrated: 8328508: Unify the signatures of the methods address_for_index() and index_for() in BOT implementations

Guoxiong Li gli at openjdk.org
Tue Mar 26 13:14:27 UTC 2024


On Wed, 20 Mar 2024 17:26:24 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> 
> This patch unifies the related methods of the block offset table in Serial, Parallel and GC. It mainly removes the methods `SerialBlockOffsetSharedArray::address_for_index`, `SerialBlockOffsetSharedArray::index_for`, `G1BlockOffsetTable::address_for_index` and `G1BlockOffsetTable::index_for` and adds the corresponding methods `addr_for_entry` and `entry_for_addr`. Their usages and the signatures of other methods are also adjusted.
> 
> I find some duplicated code of the block offset table in Serial and Parallel (and less in G1). Maybe, we should refactor the block offset table to reduce the duplicated code in the future.
> 
> Tier-1 is running locally.
> 
> Thanks for taking the time to review.
> 
> Best Regards,
> -- Guoxiong

This pull request has now been integrated.

Changeset: 472fcb6e
Author:    Guoxiong Li <gli at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/472fcb6e6e5fce4d5166a73894d1e7e4bd91bc58
Stats:     184 lines in 10 files changed: 3 ins; 50 del; 131 mod

8328508: Unify the signatures of the methods address_for_index() and index_for() in BOT implementations

Reviewed-by: ayang, tschatzl

-------------

PR: https://git.openjdk.org/jdk/pull/18405


More information about the hotspot-gc-dev mailing list