RFR: 8328508: Unify the signatures of the methods address_for_index() and index_for() in BOT implementations [v2]

Tue Mar 26 13:29:29 UTC 2024

On Tue, 26 Mar 2024 12:09:50 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Revert ObjectStartArray::block_start_reaching_into_card
>>  - Drop unnecessary type conversion.
>
> src/hotspot/share/gc/g1/g1BlockOffsetTable.hpp line 55:
> 
>> 53: 
>> 54:   // Biased array-start of BOT array for fast BOT entry translation
>> 55:   volatile u_char* _offset_base;
> 
> Maybe the type could be changed to `uint8_t` as well while we are changing this code but feel free to ignore at this point.

Filed https://bugs.openjdk.org/browse/JDK-8329096 to follow up.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18405#discussion_r1539229697