RFR: 8331208: Memory stress test that checks OutOfMemoryError stack trace fails

[David Holmes]

On Tue, 30 Apr 2024 07:22:22 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> src/hotspot/share/gc/shared/memAllocator.hpp line 139:
>> 
>>> 137:       _outer = false;
>>> 138:       _thread = nullptr;
>>> 139:     }
>> 
>> It isn't obvious to me how this part is intended to be used. I see it ties back to the retryable allocation "activate" mode, but I'm unclear what that means as well.
>
> By "this part", do you mean the `else` branch? It exists for the `!activate` case of RetryableAllocationMark which is used when the `null_on_fail` parameter of `JVMCIRuntime::new_instance_common` is true. That is, the runtime call is from compiled code that does *not* want to trigger throwing of an OOME. Graal will deopt in such cases and let the interpreter throw the exception. This ensures the OOME is reported exactly once to JVMTI.

"this part" means the "else branch" which means the null receiving constructor. Yeah that whole "null_on_fail" thing had me a bit perplexed and I see there is now a JBS issue filed. to kill it off as we always want null-on-fail.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18925#discussion_r1586048612