RFR: 8331208: Memory stress test that checks OutOfMemoryError stack trace fails

[David Holmes]

On Wed, 1 May 2024 09:34:37 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> But if this is a hidden/internal OOME then why would we treat it as a normal OOME and trigger the XX action? If the allocation routines returned null instead, we would never consider triggering the XX actions for OOME.
>
> It depends on what the purpose of the `-XX` actions is. As far as I can tell, they are for understanding when and why the JVM hits a memory limit from an external perspective. For example, until something like https://bugs.openjdk.org/browse/JDK-8328639 exists, I don't think it would be easy to discover an OOME caused by the string constant resolution done by the JIT. But maybe that doesn't matter? I'm fine with keeping the XX actions conditional if you'd prefer.

I think it is better to keep them conditional - thanks. The -XX:OnOutOfMemoryError is an action to take when a user-visible OOME would be thrown. We don't run these actions for VM allocation failures.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18925#discussion_r1586134438