RFR: 8331048: G1: Prune rebuild candidates based on G1HeapWastePercent early [v4]
Ivan Walulya
iwalulya at openjdk.org
Fri May 3 09:02:54 UTC 2024
On Fri, 3 May 2024 08:48:42 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
> Now that pruning occurs in `remark`, I wonder if those pruned regions should/can switch to remset-untracked instead.
iiuc, the `rem_set()->clear()` does that
> src/hotspot/share/gc/g1/g1CollectionSetCandidates.cpp line 228:
>
>> 226: }
>> 227:
>> 228: void G1CollectionSetCandidates::sort_retained_by_efficiency() {
>
> Why is this renaming? Checking its callers, I feel the postcondition is that both kinds of candidates are sorted -- marking-candidates can be skipped seems an impl detail.
Let me revert this!
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18970#issuecomment-2092595130
PR Review Comment: https://git.openjdk.org/jdk/pull/18970#discussion_r1588934051
More information about the hotspot-gc-dev
mailing list