RFR: 8331048: G1: Prune rebuild candidates based on G1HeapWastePercent early [v4]

[Ivan Walulya]

On Fri, 3 May 2024 08:45:30 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Ivan Walulya has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'upstream/master' into PruneBeforeRebuild
>>  - Refactor cleanup
>>  - Thomas Review
>>  - remove methods
>>  - Merge branch 'master' into PruneBeforeRebuild
>>  - remove Fixme
>>  - cleanup
>>  - Merge branch 'master' into GroupOldRegions_Remsets
>>  - save
>>  - clean up
>>  - ... and 1 more: https://git.openjdk.org/jdk/compare/d5883d10...a42cfbd1
>
> src/hotspot/share/gc/g1/g1CollectionSetCandidates.hpp line 132:
> 
>> 130:   // will cause regions with a lot of live objects and large remembered sets to end
>> 131:   // up at the end of the list.
>> 132:   static int compare_gc_efficiency(G1CollectionSetCandidateInfo* ci1, G1CollectionSetCandidateInfo* ci2);
> 
> Preexisting: I wonder if these can be static functions in cpp file, i.e. not in hpp at all.

Possible, but then they end up in different .cpp files, not sure if that is cleaner

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18970#discussion_r1589003669