RFR: 8321292: SerialGC: NewSize vs InitialHeapSize check has an off-by-one error

Albert Mingkun Yang ayang at openjdk.org
Fri May 24 08:01:01 UTC 2024


On Fri, 24 May 2024 07:49:40 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   please review this change to the warning message to improve the understanding why the change is needed.
> I tried to make the message similar to surrounding ones, adding actual values.
> 
> Testing: local compilation, manual testing
> 
> Thanks,
>   Thomas

The local var name is a bit odd, maybe `revised_new_size`?

-------------

Marked as reviewed by ayang (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19384#pullrequestreview-2076136364


More information about the hotspot-gc-dev mailing list