RFR: 8340408: Shenandoah: Remove redundant task stats printing code in ShenandoahTaskQueue

William Kemper wkemper at openjdk.org
Thu Sep 19 21:50:35 UTC 2024


On Thu, 19 Sep 2024 00:33:04 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

> [JDK-8280397](https://bugs.openjdk.org/browse/JDK-8280397) made the code redundant. 
> 
> Adopt shared implementation.

Thanks for this! Can we use the labels as requested in the review comments?

src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp line 228:

> 226:   finish_mark_work();
> 227:   assert(task_queues()->is_empty(), "Should be empty");
> 228:   TASKQUEUE_STATS_ONLY(task_queues()->print_and_reset_taskqueue_stats(""));

Could we pass `"Finish Mark"` for the label here.

src/hotspot/share/gc/shenandoah/shenandoahSTWMark.cpp line 136:

> 134: 
> 135:   assert(task_queues()->is_empty(), "Should be empty");
> 136:   TASKQUEUE_STATS_ONLY(task_queues()->print_and_reset_taskqueue_stats(""));

Could we pass `"Mark"` for the label here?

-------------

Changes requested by wkemper (Committer).

PR Review: https://git.openjdk.org/jdk/pull/21077#pullrequestreview-2316808410
PR Review Comment: https://git.openjdk.org/jdk/pull/21077#discussion_r1767638510
PR Review Comment: https://git.openjdk.org/jdk/pull/21077#discussion_r1767638220


More information about the hotspot-gc-dev mailing list