RFR: 8340408: Shenandoah: Remove redundant task stats printing code in ShenandoahTaskQueue
Zhengyu Gu
zgu at openjdk.org
Mon Sep 23 12:37:36 UTC 2024
On Thu, 19 Sep 2024 21:46:43 GMT, William Kemper <wkemper at openjdk.org> wrote:
>> [JDK-8280397](https://bugs.openjdk.org/browse/JDK-8280397) made the code redundant.
>>
>> Adopt shared implementation.
>
> src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp line 228:
>
>> 226: finish_mark_work();
>> 227: assert(task_queues()->is_empty(), "Should be empty");
>> 228: TASKQUEUE_STATS_ONLY(task_queues()->print_and_reset_taskqueue_stats(""));
>
> Could we pass `"Finish Mark"` for the label here.
The label is used for queue names in other GCs, instead of phases. I passed empty string to be consistent with old label.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21077#discussion_r1771319732
More information about the hotspot-gc-dev
mailing list