RFR: 8340408: Shenandoah: Remove redundant task stats printing code in ShenandoahTaskQueue

William Kemper wkemper at openjdk.org
Mon Sep 23 17:17:35 UTC 2024


On Mon, 23 Sep 2024 12:35:16 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp line 228:
>> 
>>> 226:   finish_mark_work();
>>> 227:   assert(task_queues()->is_empty(), "Should be empty");
>>> 228:   TASKQUEUE_STATS_ONLY(task_queues()->print_and_reset_taskqueue_stats(""));
>> 
>> Could we pass `"Finish Mark"` for the label here.
>
> The label is used for queue names in other GCs, instead of phases. I passed empty string to be consistent with old label.

Okay.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21077#discussion_r1771815824


More information about the hotspot-gc-dev mailing list