RFR: 8341015: OopStorage location decoder crashes accessing non-initalized OopStorage [v2]

Aleksey Shipilev shade at openjdk.org
Thu Sep 26 12:47:48 UTC 2024


On Thu, 26 Sep 2024 12:16:27 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Touchups
>
> src/hotspot/share/gc/shared/oopStorageSet.cpp line 89:
> 
>> 87:     const void* aligned_addr = align_down(addr, alignof(oop));
>> 88:     for (OopStorage* storage : Range<Id>()) {
>> 89:       if (storage != nullptr && storage->print_containing((oop*) aligned_addr, st)) {
> 
> Add a comment?  Something like "Might get here while handling error before storage initialization."

Sure thing, see new commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21204#discussion_r1776997613


More information about the hotspot-gc-dev mailing list