RFR: 8351892: GenShen: Remove enforcement of generation sizes [v2]
William Kemper
wkemper at openjdk.org
Tue Apr 1 22:27:07 UTC 2025
On Sat, 29 Mar 2025 00:08:06 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:
>> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Don't let old have the entire heap
>
> src/hotspot/share/gc/shenandoah/shenandoahGenerationalFullGC.cpp line 120:
>
>> 118: if (old_capacity > old_usage) {
>> 119: size_t excess_old_regions = (old_capacity - old_usage) / ShenandoahHeapRegion::region_size_bytes();
>> 120: gen_heap->transfer_to_young(excess_old_regions);
>
> should we assert result is successful? Or replace with force_transfer? (just seems bad practice to ignore a status result)
Yes, will try an assert here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24268#discussion_r2023754542
More information about the hotspot-gc-dev
mailing list