RFR: 8351892: GenShen: Remove enforcement of generation sizes [v2]

William Kemper wkemper at openjdk.org
Tue Apr 1 22:44:36 UTC 2025


On Sat, 29 Mar 2025 00:10:28 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Don't let old have the entire heap
>
> src/hotspot/share/gc/shenandoah/shenandoahGenerationalHeap.cpp line 134:
> 
>> 132:   ShenandoahHeap::initialize_heuristics();
>> 133: 
>> 134:   // Max capacity is the maximum _allowed_ capacity. This means the sum of the maximum
> 
> I don't understand the relevance of this comment.  Is there still a mximum allowed for old and a maximum allowed for young?

This comment stemmed from own confusion over fields and variables called _max_ `capacity` . I would like to rename the `_max_capacity` field to just `_capacity`. In my mind, the _max_ should be immutable, but that isn't how Shenandoah uses this field.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24268#discussion_r2023766431


More information about the hotspot-gc-dev mailing list