RFR: 8354228: Parallel: Set correct minimum of InitialSurvivorRatio [v2]
Guoxiong Li
gli at openjdk.org
Sun Apr 20 11:15:42 UTC 2025
On Thu, 10 Apr 2025 11:59:52 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
>> Updating the lower bound of InitialSurvivorRatio to match MinSurvivorRatio. The two removed test cases set conflicting Min and Intial SurvivorRatio, which, IMO, is an incorrect configuration, so I removed them.
>>
>> Test: tier1-7
>
> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
>
> review
src/hotspot/share/gc/parallel/parallelArguments.cpp line 78:
> 76: } else {
> 77: FLAG_SET_DEFAULT(InitialSurvivorRatio, MinSurvivorRatio);
> 78: }
If both `InitialSurvivorRatio` and `MinSurvivorRatio` are not set in command line and the condition `InitialSurvivorRatio < MinSurvivorRatio` is true, it seems the corresponding default/ergonomic values, we set before, are wrong. Should we guard this situation (such as printing an error message) to catch the bug in the previous code?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24556#discussion_r2051691657
More information about the hotspot-gc-dev
mailing list