RFR: 8354228: Parallel: Set correct minimum of InitialSurvivorRatio [v2]
Albert Mingkun Yang
ayang at openjdk.org
Tue Apr 22 07:55:17 UTC 2025
On Sun, 20 Apr 2025 10:35:21 GMT, Guoxiong Li <gli at openjdk.org> wrote:
> If both InitialSurvivorRatio and MinSurvivorRatio are not set in command line and the condition InitialSurvivorRatio < MinSurvivorRatio is true
When will that happen? AFAIS, if neither is set on command line, the default values should be MinSurvivorRatio == 3 and InitialSurvivorRatio == 8 (as defined in gc_globals.hpp), so `MinSurvivorRatio <= InitialSurvivorRatio` should hold.
> Should we guard this situation (such as printing an error message) to catch the bug in the previous code?
I didn't really understand your suggestion. Could you clarify what you mean by "previous code"? Or maybe some pseudo code to outline your suggestion?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24556#discussion_r2053545854
More information about the hotspot-gc-dev
mailing list