RFR: 8371420: Still sporadic failures of gc/TestAlwaysPreTouchBehavior.java#<gcname> on Linux after JDK-8359104 [v3]
Martin Doerr
mdoerr at openjdk.org
Fri Dec 19 11:57:23 UTC 2025
On Fri, 19 Dec 2025 09:35:09 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Add SkippedException for too small host memory
>
> test/hotspot/jtreg/gc/TestAlwaysPreTouchBehavior.java line 159:
>
>> 157: throw new SkippedException("cannot get RSS?");
>> 158: }
>> 159: if (available > requiredAvailable) {
>
> I'd suggest inverting the condition to "early-throw" for uninteresting cases, like above.
I agree. Having both skip cases together makes the code better readable and avoids an extra level of curly braces.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28735#discussion_r2634860315
More information about the hotspot-gc-dev
mailing list