RFR: 8371420: Still sporadic failures of gc/TestAlwaysPreTouchBehavior.java#<gcname> on Linux after JDK-8359104 [v3]
Matthias Baesken
mbaesken at openjdk.org
Fri Dec 19 12:47:13 UTC 2025
On Fri, 19 Dec 2025 11:54:36 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:
>> test/hotspot/jtreg/gc/TestAlwaysPreTouchBehavior.java line 159:
>>
>>> 157: throw new SkippedException("cannot get RSS?");
>>> 158: }
>>> 159: if (available > requiredAvailable) {
>>
>> I'd suggest inverting the condition to "early-throw" for uninteresting cases, like above.
>
> I agree. Having both skip cases together makes the code better readable and avoids an extra level of curly braces.
Makes sense, I adjusted the coding.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28735#discussion_r2634984023
More information about the hotspot-gc-dev
mailing list