RFR: 8348594: Shenandoah: Do not penalize for degeneration when not the fault of triggering heuristic [v2]

Kelvin Nilsen kdnilsen at openjdk.org
Mon Feb 10 19:55:12 UTC 2025


On Tue, 4 Feb 2025 16:08:02 GMT, Paul Hohensee <phh at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Respond to reviewer feedback
>
> src/hotspot/share/gc/shenandoah/heuristics/shenandoahHeuristics.hpp line 87:
> 
>> 85:   size_t _declined_trigger_count;         // This counts how many times since previous GC finished that this
>> 86:                                           //  heuristic has answered false to should_start_gc().
>> 87:   size_t _previous_trigger_declinations;  // This represents the value of _declined_trigger_count as captured at the
> 
> Maybe the name should be _most_recent_declined_trigger_count, which relates it directly to _declined_trigger_count.

Thanks for suggestion.  I'm making this change.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23305#discussion_r1949788716


More information about the hotspot-gc-dev mailing list