RFR: 8348594: Shenandoah: Do not penalize for degeneration when not the fault of triggering heuristic [v2]

[Kelvin Nilsen]

On Tue, 4 Feb 2025 16:04:34 GMT, Paul Hohensee <phh at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Respond to reviewer feedback
>
> src/hotspot/share/gc/shenandoah/heuristics/shenandoahHeuristics.cpp line 261:
> 
>> 259: 
>> 260: void ShenandoahHeuristics::record_success_concurrent() {
>> 261:   _start_gc_is_pending = false;
> 
> The name _start_gc_is_pending implies that it should be set false as soon as a gc cycle starts, not when it finishes. Maybe _gc_pending? Or maybe setting it false at the end of a gc cycle is a bug? :)

You make a good point.  I'll change the control flow to cancel the trigger as soon as we start up the GC.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23305#discussion_r1949798178