RFR: 8346920: Serial: Support allocation in old generation before GC [v2]

[Albert Mingkun Yang]

On Mon, 6 Jan 2025 14:05:04 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Albert Mingkun Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - review
>>  - Merge branch 'master' into s1-gc-time-ratio
>>  - s1-gc-time-ratio
>
> src/hotspot/share/gc/serial/serialHeap.cpp line 334:
> 
>> 332: 
>> 333:       bool first_only = !should_try_older_generation_allocation(size)
>> 334:                      && is_long_enough_from_prev_gc_pause_end();
> 
> Is the `first_only` actually `young_only`? It means that the allocation is only attempted in young generation?

That's true. I believe Serial used to support >2 generations, so some generic names are left as is. Fixing it requires updating in multiple places, such as the method name `older_generation`, arg in `attempt_allocation`, etc. How about we do that invasive but pure refactoring in its own PR?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22899#discussion_r1904230427