RFR: 8361238: G1 tries to get CPU info from terminated threads at shutdown
Thomas Schatzl
tschatzl at openjdk.org
Thu Jul 3 07:01:53 UTC 2025
On Wed, 2 Jul 2025 15:58:46 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Hi all,
>>
>> please review this fix after the recent changes in void JDK-8274051 where G1 tries to get thread cpu time on already terminated threads.
>>
>> The fix is to move the printing/statistics before stopping the threads. This seems fine for the two implementors of the method.
>>
>> In a future change, since so few GCs implement `print_tracing_info`, the call should probably move to `stop()/begin_exit()`.
>>
>> Testing: gha
>>
>> Thanks,
>> Thomas
>
> Looks good.
Thanks @kimbarrett @sangheon for your reviews
-------------
PR Comment: https://git.openjdk.org/jdk/pull/26086#issuecomment-3031103688
More information about the hotspot-gc-dev
mailing list