RFR: 8357445: G1: Time-Based Heap Uncommit During Idle Periods [v2]

[Ivan Walulya]

On Wed, 16 Jul 2025 20:49:30 GMT, Monica Beckwith <mbeckwit at openjdk.org> wrote:

>> src/hotspot/share/gc/g1/g1HeapEvaluationTask.cpp line 44:
>> 
>>> 42: void G1HeapEvaluationTask::task() {
>>> 43:   // This runs on WatcherThread during idle periods - perfect for time-based evaluation!
>>> 44:   log_debug(gc, sizing)("Starting heap evaluation");
>> 
>> For existing Heap Resizing tasks, we use the tags `(gc, ergo, heap)`, I would suggest we maintain that.
>
>> For existing Heap Resizing tasks, we use the tags `(gc, ergo, heap)`, I would suggest we maintain that.
> 
> I'd like to discuss the logging tag choice. While I understand the consistency argument for using (gc,ergo,heap), I believe (gc,sizing) is more appropriate here because:
> 
> 1. This is a distinct sizing mechanism, not traditional ergonomic heap management
> 2. Users troubleshooting time-based sizing specifically will benefit from a dedicated tag
> 3. It aligns with the feature name and purpose
> 4. It provides better separation of concerns for logging
> 
> Would you be open to keeping (gc,sizing) for semantic clarity?

My argument is related to consistency, if there are reasons to have this logging distinct from the `(gc, ergo, heap)`, that is fine by me.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26240#discussion_r2211618240