RFR: 8361055: Serial: Inline SerialHeap::process_roots

[Stefan Karlsson]

On Mon, 30 Jun 2025 09:14:00 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> src/hotspot/share/gc/serial/serialFullGC.cpp line 492:
>> 
>>> 490:                                             true);
>>> 491: 
>>> 492:     ClassLoaderDataGraph::always_strong_cld_do(&follow_cld_closure);
>> 
>> The old code treated `!ClassUnloading` differently. It's not clear to me why this change is correct.
>
> `always_strong_cld_do` does `ClassUnloading` checking internally.
> 
> Semantically, for full-gc marking, we process always-strong clds only. (Ofc, if class unloading is off, all clds are always-strong.)

I see.

After having not looked at this for a while I find the "always" part of the name both redundant and even slightly misleading. This function could be named "strong_cld_do" (or even strong_clds_do, but the other functions are also miss the s). This could be a cleanup for the future.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26038#discussion_r2174683077