RFR: 8361055: Serial: Inline SerialHeap::process_roots [v2]

Albert Mingkun Yang ayang at openjdk.org
Mon Jun 30 10:35:38 UTC 2025


On Mon, 30 Jun 2025 09:48:08 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Both orderings are fine. (`ScavengeRootsTask` processes old-to-young pointers first). I changed that to avoid a local variable. Can revert it back if you prefers that.
>
> OK. I understand. It could be worth adding a comment explaining that we're scanning objects that were old before relocation started. FWIW, if you want to keep it at the top then I think you can get rid of "_old_gen->space()->top()" from this function and extract it inside scan_old_to_young_refs instead.

Added comment and inlined `space()->top()` to the callee.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26038#discussion_r2174759782


More information about the hotspot-gc-dev mailing list