Integrated: 8357307: VM GC operations should have a public gc_succeeded()

Thomas Schatzl tschatzl at openjdk.org
Wed May 28 15:52:58 UTC 2025


On Tue, 27 May 2025 15:43:10 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>    please review this cleanup that changes `VM_GC_Operation` to use `gc_succeeded` instead of `prologue_succeeded()`to indicate that a GC has been executed (once a GC is started, it will always finish, so the only reason that a VM op does not get executed is that we decide in the prologue that there has already been a GC).
> 
> After recent changes the change is/was mostly a renaming of the `prologue_succeeded`method - there is only one case for G1 where additional checks can cause no execution of the GC (e.g. because we started a low-priority concurrent mark and we are already currently marking. No point for doing a GC in that case).
> 
> Testing: tier1-4, gha
> 
> Thanks,
>   Thomas

This pull request has now been integrated.

Changeset: 2e6838a2
Author:    Thomas Schatzl <tschatzl at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/2e6838a20d52e9fa0a3b7322f2cb548e034b5d83
Stats:     7 lines in 5 files changed: 0 ins; 2 del; 5 mod

8357307: VM GC operations should have a public gc_succeeded()

Reviewed-by: ayang, iwalulya

-------------

PR: https://git.openjdk.org/jdk/pull/25469


More information about the hotspot-gc-dev mailing list