RFR: 8357307: VM GC operations should have a public gc_succeeded()
Thomas Schatzl
tschatzl at openjdk.org
Wed May 28 15:52:57 UTC 2025
On Wed, 28 May 2025 10:54:05 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:
>> Hi all,
>>
>> please review this cleanup that changes `VM_GC_Operation` to use `gc_succeeded` instead of `prologue_succeeded()`to indicate that a GC has been executed (once a GC is started, it will always finish, so the only reason that a VM op does not get executed is that we decide in the prologue that there has already been a GC).
>>
>> After recent changes the change is/was mostly a renaming of the `prologue_succeeded`method - there is only one case for G1 where additional checks can cause no execution of the GC (e.g. because we started a low-priority concurrent mark and we are already currently marking. No point for doing a GC in that case).
>>
>> Testing: tier1-4, gha
>>
>> Thanks,
>> Thomas
>
> Marked as reviewed by iwalulya (Reviewer).
Thanks @walulyai @albertnetymk for your reviews
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25469#issuecomment-2916827168
More information about the hotspot-gc-dev
mailing list