RFR: 8372285: G1: Micro-optimize x86 barrier code [v3]

Aleksey Shipilev shade at openjdk.org
Fri Nov 21 16:09:20 UTC 2025


On Fri, 21 Nov 2025 14:20:06 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make some backward branches explicitly short
>
> src/hotspot/cpu/x86/gc/g1/g1BarrierSetAssembler_x86.cpp line 208:
> 
>> 206: 
>> 207:   // Jump out if done, or fall-through to runtime.
>> 208:   // "Done" is far away, so jump cannot be short.
> 
> I believe "Done" refers to `L_done`, so I wonder if we use that directly.

Yes, is it about `L_done`. Fixed the comment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28446#discussion_r2550250301


More information about the hotspot-gc-dev mailing list