RFR: 8372285: G1: Micro-optimize x86 barrier code [v4]

Aleksey Shipilev shade at openjdk.org
Fri Nov 21 16:09:17 UTC 2025


> We know from [JDK-8372284](https://bugs.openjdk.org/browse/JDK-8372284) that G1 C2 stubs can take ~10% of total instructions. So minor optimizations in hand-written assembly pay off for code density. This PR does a little x86-specific polishing: `testptr` where possible, short forward branches where possible. I rewired some code to make it abundantly clear the branches in question are short. It also makes clear that lots of the affected methods are essentially fall-through.
> 
> The patch is deliberately on simpler side, so we can backport it to 25u, if need arises.
> 
> Additional testing:
>  - [x] Linux x86_64 server fastdebug, `tier1`
>  - [ ]  Linux x86_64 server fastdebug, `all`

Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:

 - Adjust label name
 - Merge branch 'master' into JDK-8372285-g1-barrier-micro
 - Make some backward branches explicitly short
 - Comment
 - Shorten a few more branches
 - Also reflow generate_pre_barrier_slow_path, so it is obvious the branches are short
 - More touchups
 - Also optimize queue insertion
 - Touchups
 - WIP

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/28446/files
  - new: https://git.openjdk.org/jdk/pull/28446/files/1f57d0d9..c23bac46

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=28446&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28446&range=02-03

  Stats: 1409 lines in 83 files changed: 622 ins; 421 del; 366 mod
  Patch: https://git.openjdk.org/jdk/pull/28446.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/28446/head:pull/28446

PR: https://git.openjdk.org/jdk/pull/28446


More information about the hotspot-gc-dev mailing list