RFR: 8365880: Shenandoah: Unify memory usage accounting in ShenandoahFreeSet [v3]
Kelvin Nilsen
kdnilsen at openjdk.org
Fri Oct 3 18:41:52 UTC 2025
On Fri, 12 Sep 2025 17:04:19 GMT, William Kemper <wkemper at openjdk.org> wrote:
>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> another tweak to make GHA gtest happy
>
> src/hotspot/share/gc/shenandoah/shenandoahGeneration.hpp line 134:
>
>> 132: virtual size_t used_regions_size() const;
>> 133: virtual size_t free_unaffiliated_regions() const;
>> 134: size_t used() const override {
>
> This is already virtual (since it is marked as `override`) so it makes sense to put these different behaviors in the different generation subclasses.
Thanks. This is done now.
> src/hotspot/share/gc/shenandoah/shenandoahGeneration.hpp line 154:
>
>> 152: size_t available() const override;
>> 153: size_t available_with_reserve() const;
>> 154: size_t used_including_humongous_waste() const {
>
> Can we get rid of this method? Just have callers call `used` now?
Correct. It has been removed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26867#discussion_r2402976401
PR Review Comment: https://git.openjdk.org/jdk/pull/26867#discussion_r2402978481
More information about the hotspot-gc-dev
mailing list