RFR: 8365880: Shenandoah: Unify memory usage accounting in ShenandoahFreeSet [v3]

Kelvin Nilsen kdnilsen at openjdk.org
Fri Oct 3 19:49:44 UTC 2025


On Fri, 12 Sep 2025 17:19:53 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   another tweak to make GHA gtest happy
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp line 55:
> 
>> 53: class ShenandoahLeftRightIterator {
>> 54: private:
>> 55:   index_type _idx;
> 
> Changing this to a different type introduces a lot of noise in the review. It was compiling before this change, can we figure out if it is really necessary to change this type?

Thanks for insisting on highest standards.  I think I've figured out how to resolve the conflicts with multiple definitions of idx_t and committed a change.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26867#discussion_r2403182952


More information about the hotspot-gc-dev mailing list