RFR: 8365880: Shenandoah: Unify memory usage accounting in ShenandoahFreeSet [v14]

Kelvin Nilsen kdnilsen at openjdk.org
Tue Oct 7 22:07:10 UTC 2025


On Tue, 7 Oct 2025 22:03:34 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 136:
>> 
>>> 134: 
>>> 135: #ifndef PRODUCT
>>> 136:   void dump_bitmap_row(idx_t region_idx) const;
>> 
>> maybe revert this.  bitmap rows are not idx_t.
>
> After review, I think it is appropriate that the argument type be declared idx_t.

After review of context, I believe it is appropriate that these arguments be declared idx_t.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26867#discussion_r2412033488


More information about the hotspot-gc-dev mailing list