RFR: 8365880: Shenandoah: Unify memory usage accounting in ShenandoahFreeSet [v14]

Kelvin Nilsen kdnilsen at openjdk.org
Tue Oct 7 22:07:09 UTC 2025


On Fri, 3 Oct 2025 21:54:32 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   simplify implementation of promote_in_place
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 136:
> 
>> 134: 
>> 135: #ifndef PRODUCT
>> 136:   void dump_bitmap_row(idx_t region_idx) const;
> 
> maybe revert this.  bitmap rows are not idx_t.

After review, I think it is appropriate that the argument type be declared idx_t.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26867#discussion_r2412032037


More information about the hotspot-gc-dev mailing list