RFR: 8366881: Parallel: Obsolete HeapMaximumCompactionInterval [v2]

Francesco Andreuzzi duke at openjdk.org
Mon Sep 8 15:04:30 UTC 2025


On Mon, 8 Sep 2025 14:53:16 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> src/hotspot/share/runtime/arguments.cpp line 571:
>> 
>>> 569: 
>>> 570:   { "PretenureSizeThreshold",       JDK_Version::undefined(), JDK_Version::jdk(26), JDK_Version::jdk(27) },
>>> 571:   { "HeapMaximumCompactionInterval",JDK_Version::undefined(), JDK_Version::jdk(26), JDK_Version::jdk(27) },
>> 
>> Maybe add a space?
>> Suggestion:
>> 
>>   { "HeapMaximumCompactionInterval", JDK_Version::undefined(), JDK_Version::jdk(26), JDK_Version::jdk(27) },
>
> That did cross my mind. However, I went for the current version as I feel aligning with previous line (identical obsolete/expire version) is more important.
> 
> WDYT?

What I would do in this case is to make L571 look nice and adapt the alignment of L570 accordingly, but I'm not sure if there's anything about this in the style guide. Feel free to ignore the comment

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27091#discussion_r2330523844


More information about the hotspot-gc-dev mailing list