RFR: 8367409: G1: Remove unused G1MonotonicArena::Segment::copy_to()

Thomas Schatzl tschatzl at openjdk.org
Fri Sep 12 12:00:54 UTC 2025


On Thu, 11 Sep 2025 14:47:31 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> The code compiles.
>
> src/hotspot/share/gc/g1/g1MonotonicArena.hpp line 177:
> 
>> 175: 
>> 176:   static Segment* create_segment(uint slot_size, uint num_slots, Segment* next, MemTag mem_tag);
>> 177:   static void delete_segment(Segment *segment);
> 
> I'd suggest keeping the original `Segment*` type to be consistent with surrounding code.

Also, I think this is part of the style guideline to keep the `*` at the type, even if the compiler parses it differently.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27221#discussion_r2343518658


More information about the hotspot-gc-dev mailing list