RFR: 8367409: G1: Remove unused G1MonotonicArena::Segment::copy_to()
Leo Korinth
lkorinth at openjdk.org
Fri Sep 12 12:00:54 UTC 2025
On Fri, 12 Sep 2025 08:59:15 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> src/hotspot/share/gc/g1/g1MonotonicArena.hpp line 177:
>>
>>> 175:
>>> 176: static Segment* create_segment(uint slot_size, uint num_slots, Segment* next, MemTag mem_tag);
>>> 177: static void delete_segment(Segment *segment);
>>
>> I'd suggest keeping the original `Segment*` type to be consistent with surrounding code.
>
> Also, I think this is part of the style guideline to keep the `*` at the type, even if the compiler parses it differently.
I have now turned off auto format, sorry for that. I much prefer the asterisk close to the type.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27221#discussion_r2343927662
More information about the hotspot-gc-dev
mailing list