RFR: 8365880: Shenandoah: Unify memory usage accounting in ShenandoahFreeSet [v3]
Kelvin Nilsen
kdnilsen at openjdk.org
Fri Sep 12 18:20:15 UTC 2025
On Wed, 10 Sep 2025 20:42:42 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:
>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> another tweak to make GHA gtest happy
>
> src/hotspot/share/gc/shenandoah/heuristics/shenandoahAdaptiveHeuristics.cpp line 372:
>
>> 370: _last_sample_time = now;
>> 371: _last_sample_value = allocated;
>> 372: }
>
> This was a bug. If we don't update the average, we should not restart the time until next sample and we should not overwrite the value of _last_sample_value.
Let's split this out into a different PR.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26867#discussion_r2345013011
More information about the hotspot-gc-dev
mailing list