RFR: 8365880: Shenandoah: Unify memory usage accounting in ShenandoahFreeSet [v3]
Kelvin Nilsen
kdnilsen at openjdk.org
Sun Sep 28 23:45:18 UTC 2025
On Fri, 12 Sep 2025 17:37:01 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:
>> src/hotspot/share/gc/shenandoah/heuristics/shenandoahAdaptiveHeuristics.cpp line 372:
>>
>>> 370: _last_sample_time = now;
>>> 371: _last_sample_value = allocated;
>>> 372: }
>>
>> This was a bug. If we don't update the average, we should not restart the time until next sample and we should not overwrite the value of _last_sample_value.
>
> Let's split this out into a different PR.
I reverted these changes, addressed this issue in separate PR https://github.com/openjdk/jdk/pull/27398, and merged from mainline.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26867#discussion_r2386423882
More information about the hotspot-gc-dev
mailing list