RFR: 8368251: Parallel: Refactor lgrp_id used in MutableNUMASpace [v2]

Thomas Schatzl tschatzl at openjdk.org
Wed Sep 24 09:39:18 UTC 2025


On Wed, 24 Sep 2025 06:48:28 GMT, Joel Sikström <jsikstro at openjdk.org> wrote:

>> Or just a "must be" :)
>
> I have added an assert in the only place we use it where it mustn't be -1. Do you think this is enough or should we also assert during thread creation, with a comment stating that there is thread state dependent on NUMA support, which we skip here.
> 
> In the new `MutableNUMASpace::LGRPSpace *MutableNUMASpace::lgrp_space_for_thread(Thread* thr)`:
> 
> assert(lgrp_id != -1, "lgrp_id must be set during thread creation");

I think that's good enough.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27424#discussion_r2375187853


More information about the hotspot-gc-dev mailing list