RFR(XXS): 8203457: Add back missing full buffer notification

Markus Gronlund markus.gronlund at oracle.com
Mon May 21 08:44:40 UTC 2018


Greetings,

Can I please have a review for the following fix:

Summary:

After open sourcing, it was noted that the "dumponexit" generated recording file size do not exceed ~10 mb. 10 mb is the size of the default memory buffer system.

Turns out that some logic were lost in code refactoring:

On a full global buffer, the notification is never sent to the recorder thread for it to flush to disk. This means the in-memory buffer system fills up until eventually no free space is left. At this point threads will start to discard data and write "data loss" events.

Need to add back the missing notification.

Bug: https://bugs.openjdk.java.net/browse/JDK-8203457

Webrev: http://cr.openjdk.java.net/~mgronlun/8203457/webrev00/

Thanks to Claes and Stefan for pointing out the issue.

Thanks
Markus



More information about the hotspot-jfr-dev mailing list