RFR(XS): 8027760: JFC schema condition should not have defaults

Markus Gronlund markus.gronlund at oracle.com
Mon May 21 08:56:06 UTC 2018


Looks good.

Markus

-----Original Message-----
From: Erik Gahlin 
Sent: den 19 maj 2018 21:11
To: hotspot-jfr-dev at openjdk.java.net
Subject: RFR(XS): 8027760: JFC schema condition should not have defaults

Hi,

Could I please have a review of this small fix.

The schema for .jfc files is incorrect. The true or false element should not default to "true" or "false" in a condition element, they should remain unset if the user has not specified a value. This is internal documentation issue, the schema is not used in the code and JMC assumes this is the case.

Webrev:
http://cr.openjdk.java.net/~egahlin/8027760.1

Bug:
https://bugs.openjdk.java.net/browse/JDK-8027760

Thanks
Erik


More information about the hotspot-jfr-dev mailing list