RFR(S): 8217744: [TESTBUG] JFR TestShutdownEvent fails on some systems due to process surviving SIGINT

Erik Gahlin erik.gahlin at oracle.com
Tue Jan 29 21:26:59 UTC 2019


Hi Misha,

I noticed the "60_1000" when I reviewed you change the first time, but 
isn't it better to just let the process hang "forever" (i.e. 600 s) if 
it can't be killed than an arbitrary 10 s, which may or may not be 
sufficient?

Determinism is nice when analyzing test failures. Remove the sleep, 
perhaps adding a System.out, or just let it sleep indefinitely, i.e 
Thread.sleep(1_000_000).

Or would that not work?

Thanks
Erik

> Please review: this change updated the handling of cases where child 
> process survives the signal. If it does,
> we record this and skip verification, and continue with the rest of 
> the test.
>
>     JBS: https://bugs.openjdk.java.net/browse/JDK-8217744
>     Webrev: http://cr.openjdk.java.net/~mseledtsov/8217744.00/
>     Testing:
>         1. Locally: Mac OSX, both as is and simulating the child 
> process surviving the SIGINT - PASS
>         2. Multi-platform automated system: Linux-x64, Win-x64, Mac, 
> Sol-Spc - All PASS
>         3. SAP engineer tested the patch on the SAP systems where it 
> originally failed - Pass
>             Goetz, many thanks for testing the patch.
>
> Thank you,
> Misha
>



More information about the hotspot-jfr-dev mailing list