RFR: 8250912: Recording#copy() doesn't copy the flush interval

[Chihiro Ito]

Hi Jaroslav,

Thank you for reviewing and sharing your thoughts.

Other copied values are tested as following, but what should I do in this case?

Asserts.assertEquals(recording.getMaxSize(), original.getMaxSize());

Regards
Chihiro

2020年8月4日(火) 18:41 Jaroslav Bachorík <jaroslav.bachorik at datadoghq.com>:
>
> Hi Chihiro,
>
> the change looks good! Can't really answer the question about
> Recording#getFlushInterval being package private - my guess would be
> to avoid revving up the API but it is just a guess.
>
> Cheers,
>
> -JB-
>
> On Sun, Aug 2, 2020 at 5:13 PM Chihiro Ito <chiroito107 at gmail.com> wrote:
> >
> > Hi,
> >
> > Could you review this tiny fix, please?
> >
> > JBS : https://bugs.openjdk.java.net/browse/JDK-8250912
> > Webrev : http://cr.openjdk.java.net/~cito/JDK-8250912/webrev.00/
> >
> > I have a question involving flush interval.
> > Why is Recording#getFlushInterval method package-private? I would like
> > to write a test using this method. However, in test case, I could not
> > access this method.
> >
> > Regards,
> > Chihiro