RFR: JDK-8252113: Move jfr man page into jfr module
Magnus Ihse Bursie
magnus.ihse.bursie at oracle.com
Fri Sep 4 07:56:25 UTC 2020
On 2020-08-26 15:15, Adam Farley8 wrote:
> Hi All,
>
> Should jfr.1 be moved from java.base to the jdk.jfr module source
> directory, as indicated here?
>
> Webrev: http://cr.openjdk.java.net/~afarley/8252113/webrev/
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8252113
>
> It seems to me that it should, as man pages should be with their code (as
> appears the case in other modules), but perhaps there's something I'm not
> seeing.
>
> Thoughts and reviews welcome.
Hi Adam,
You are absolutely correct - the man pages should reside in the same
module as the corresponding executable. Thank you for noticing this!
However, the troff man page in the open repo is generated from a
corresponding markdown file which is (unfortunately still) in closed,
and they should be moved in tandem. Do you mind if I take over the bug
so I can move both files?
/Magnus
>
> Best Regards
>
> Adam Farley
> IBM Runtimes
>
>
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with number
> 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
>
More information about the hotspot-jfr-dev
mailing list