RFR: JDK-8252113: Move jfr man page into jfr module

[Adam Farley8]

Hi Magnus,

I don't mind. Go ahead. :)

Best Regards

Adam Farley 
IBM Runtimes


Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com> wrote on 04/09/2020 
08:56:25:

> From: Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com>
> To: Adam Farley8 <adam.farley at uk.ibm.com>, 
hotspot-jfr-dev at openjdk.java.net
> Date: 04/09/2020 08:56
> Subject: [EXTERNAL] Re: RFR: JDK-8252113: Move jfr man page into jfr 
module
> 
> On 2020-08-26 15:15, Adam Farley8 wrote:
> > Hi All,
> >
> > Should jfr.1 be moved from java.base to the jdk.jfr module source
> > directory, as indicated here?
> >
> > Webrev: INVALID URI REMOVED
> 
u=http-3A__cr.openjdk.java.net_-7Eafarley_8252113_webrev_&d=DwICaQ&c=jf_iaSHvJObTbx-
> siA1ZOg&r=P5m8KWUXJf-
> 
CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=3bdk4Pwk_YbUCZJnkBdvr0ENLAonC0xGZiKGTlikhgs&s=94jGAsejvkBfxQTKJ0ZFB4zJV88P-
> DEEIFPOrQAS1_M&e= 
> >
> > Bug: INVALID URI REMOVED
> 
u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8252113&d=DwICaQ&c=jf_iaSHvJObTbx-
> siA1ZOg&r=P5m8KWUXJf-
> 
CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=3bdk4Pwk_YbUCZJnkBdvr0ENLAonC0xGZiKGTlikhgs&s=9tYUqzIw30DiDjl0_O3dqz_BKDZYxKyNy_q3XLS17lg&e=
> >
> > It seems to me that it should, as man pages should be with their code 
(as
> > appears the case in other modules), but perhaps there's something I'm 
not
> > seeing.
> >
> > Thoughts and reviews welcome.
> Hi Adam,
> 
> You are absolutely correct - the man pages should reside in the same 
> module as the corresponding executable. Thank you for noticing this!
> 
> However, the troff man page in the open repo is generated from a 
> corresponding markdown file which is (unfortunately still) in closed, 
> and they should be moved in tandem. Do you mind if I take over the bug 
> so I can move both files?
> 
> /Magnus
> 
> >
> > Best Regards
> >
> > Adam Farley
> > IBM Runtimes
> >
> >
> > Unless stated otherwise above:
> > IBM United Kingdom Limited - Registered in England and Wales with 
number
> > 741598.
> > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 
3AU
> >
> 

Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 
741598. 
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU