RFR: 8253050: jfr disassemble command processes --max-chunks incorrectly

Erik Gahlin erik.gahlin at oracle.com
Fri Sep 11 13:26:12 UTC 2020


Hello,

Looks good. Thanks for fixing this.

Erik

> On 11 Sep 2020, at 14:13, Ekaterina Vergizova <katya at azul.com> wrote:
> 
> Hello,
> 
> could I have a review of this fix.
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8253050
> Webrev: https://cr.openjdk.java.net/~apetushkov/8253050/webrev.00/
> 
> The problem is caused by Disassemble.combineChunkSizes() implementation that checks maxChunks after incrementation of fileSize, therefore the first output file has extra chunk.
> 
> Testing:
> jdk/jdk/jfr/*
> 
> Thanks,
> Ekaterina
> 



More information about the hotspot-jfr-dev mailing list